Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTPS watermark #87

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

jeffkause
Copy link
Contributor

@jeffkause jeffkause commented Nov 17, 2023

🗣 Description

Lighten CISA watermark behind the report pages.

💭 Motivation and context

Fixes dark watermark issue in the HTTPS report Table of Contents.

Screen Shot 2023-11-17 at 12 35 30 PM

🧪 Testing

Ran test report to verify the CISA watermark is transparent and the words on the pages can be read.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Deploy this change to production.

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You committed a bunch of files that you should not have.

docker-compose.yml Outdated Show resolved Hide resolved
.DS_Store Outdated Show resolved Hide resolved
output/.DS_Store Outdated Show resolved Hide resolved
output/artifacts/.DS_Store Outdated Show resolved Hide resolved
output/artifacts/ocsp-crl.csv Outdated Show resolved Hide resolved
output/artifacts/reporting/.DS_Store Outdated Show resolved Hide resolved
src/report.sh Outdated Show resolved Hide resolved
src/secrets/database_creds.yml Outdated Show resolved Hide resolved
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality version bump This issue or pull request increments the version number labels Nov 17, 2023
@jsf9k
Copy link
Member

jsf9k commented Nov 17, 2023

We will want a version bump for these changes as well.

Moving the watermark information from the file header to the Table of Contents, reduces the opacity of the watermark from 100% to 10%. Followed the changes from cisagov/trustymail_reporter#54.
@jeffkause jeffkause force-pushed the HTTPS-watermark-Update branch from 08ea9cf to 4c40316 Compare November 17, 2023 20:17
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jeffkause!

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@jsf9k jsf9k merged commit 58d1067 into cisagov:develop Nov 20, 2023
7 checks passed
@jsf9k
Copy link
Member

jsf9k commented Nov 20, 2023

I updated production to use the Docker image from release 1.2.14 in production. That is the version that will get used in next weekend's BOD 18-01 scanning run.

@jeffkause jeffkause deleted the HTTPS-watermark-Update branch November 20, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality version bump This issue or pull request increments the version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants