Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to main menu, body text in a few specific areas, mobile device rendering fixes #65

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

daniel-s-valencia
Copy link
Contributor

@daniel-s-valencia daniel-s-valencia commented Dec 4, 2024

Update the main menu so that the "key information" menu item does not overflow onto two lines for medium / small laptop size screens. Update the executive order link to open in a new tab. Increase the padding between the menu items slightly. Update certain body text for clarity. Added mobile-specific CSS to fix text clipping issues.

@daniel-s-valencia
Copy link
Contributor Author

Before and after videos.

before.mp4
after.mp4

Updated website copy in several areas for clarity and specificity, and fixed a few minor errors.
Final fixes for PR cisagov#65 including mobile device-specific responsive design to prevent text clipping in the FAQ and rules area, and better text handling in general on small devices.
Copy link
Contributor Author

@daniel-s-valencia daniel-s-valencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ColtonCISA Ready for approval/commit. Thanks!

@daniel-s-valencia daniel-s-valencia changed the title Minor fixes to main menu and open executive order link in new tab Fixes to main menu, body text in a few specific areas, mobile device rendering fixes Dec 11, 2024
@ColtonCISA ColtonCISA merged commit 7aa3094 into cisagov:main Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants