-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new hardening role #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
version bump
This issue or pull request increments the version number
dependencies
Pull requests that update a dependency file
security
This issue or pull request addresses a security issue
labels
Nov 3, 2023
jsf9k
force-pushed
the
improvement/use-new-hardening-role
branch
from
November 3, 2023 15:27
7cf5da9
to
bbb4d49
Compare
Merged
4 tasks
I verified that using these changes results in an OpenVPN AMI that functions as expected |
jsf9k
requested review from
dav3r,
felddy,
jasonodoom and
mcdonnnj
as code owners
November 3, 2023 21:10
dv4harr10
approved these changes
Nov 6, 2023
dav3r
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
We can do this because cisagov/ansible-role-hardening-2#1 has been merged.
This agrees with the changes in cisagov/skeleton-tf-module#188.
dav3r
approved these changes
Dec 13, 2023
jasonodoom
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
security
This issue or pull request addresses a security issue
version bump
This issue or pull request increments the version number
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull requests switches to the new cisagov/ansible-role-hardening-2 that @bra1ncramp created.
💭 Motivation and context
The new hardening role takes care of some security findings that were identified by the security team.
🧪 Testing
All automated tests pass. I also built and deployed a new AMI with these changes for our staging COOL environment. I was able to verify that the new AMI still functions as intended.
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist