Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the OpenVPN AMI on a Graviton (AMD64) instance #111

Closed
wants to merge 3 commits into from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jul 5, 2024

🗣 Description

This pull request modifies the Packer code to build the OpenVPN AMI on a Graviton (AMD64) instance.

💭 Motivation and context

Running the AMI on Graviton should be cheaper and better for the environment.

🧪 Testing

All automated tests pass. I also built a staging AMI with these changes and verified that it functions as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.
  • Build and test a staging AMI with these changes.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added breaking change This issue or pull request involves changes to existing functionality version bump This issue or pull request increments the version number packer Pull requests that update Packer code labels Jul 5, 2024
@jsf9k jsf9k self-assigned this Jul 5, 2024
@jsf9k jsf9k changed the title Build the Terraformer AMI on a Graviton (AMD64) instance Build the OpenVPN AMI on a Graviton (AMD64) instance Jul 5, 2024
@jsf9k
Copy link
Member Author

jsf9k commented Jul 8, 2024

The CDM Nessus agent does not support ARM64 on Debian, although it does on Ubuntu.

@mcdonnnj
Copy link
Member

The CDM Nessus agent does not support ARM64 on Debian, although it does on Ubuntu.

Do you think the Ubuntu package may work given the relationship between Ubuntu and Debian?

@jsf9k
Copy link
Member Author

jsf9k commented Jul 23, 2024

The CDM Nessus agent does not support ARM64 on Debian, although it does on Ubuntu.

Do you think the Ubuntu package may work given the relationship between Ubuntu and Debian?

My thought was to convert to an Ubuntu base AMI instead of restoring to such chicanery.

@jsf9k
Copy link
Member Author

jsf9k commented Aug 15, 2024

Closed in favor of #112.

@jsf9k jsf9k closed this Aug 15, 2024
@jsf9k jsf9k deleted the feature/graviton branch August 15, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This issue or pull request involves changes to existing functionality packer Pull requests that update Packer code version bump This issue or pull request increments the version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants