Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove resources that support the Tanium CDM agent #109

Merged
merged 4 commits into from
May 20, 2024
Merged

Remove resources that support the Tanium CDM agent #109

merged 4 commits into from
May 20, 2024

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented May 17, 2024 •
edited
Loading

🗣 Description

This pull request removes all resources that support the Tanium CDM agent.

💭 Motivation and context

Partially resolves #107.

See also:

🧪 Testing

All automated tests pass. I also built a staging AMI with these changes and verified that it:

  • Does not have the Tanium agent installed
  • Functions as expected

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.
  • Build and test a staging AMI with these changes.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number dependencies Pull requests that update a dependency file terraform Pull requests that update Terraform code security This issue or pull request addresses a security issue ansible Pull requests that update Ansible code labels May 17, 2024
@jsf9k jsf9k self-assigned this May 17, 2024
This was referenced May 17, 2024
Merged
Merged
@jsf9k jsf9k force-pushed the improvement/remove-tanium branch from 91e9e67 to 47258cf Compare May 17, 2024 14:31
@jsf9k
Remove resources that support the Tanium CDM agent
87dc12f 
The Tanium CDM agent is being retired.  See #107 for more details.
@jsf9k jsf9k force-pushed the improvement/remove-tanium branch from 47258cf to 87dc12f Compare May 17, 2024 23:31
@jsf9k jsf9k marked this pull request as ready for review May 18, 2024 19:03
@jsf9k jsf9k requested a review from a team May 18, 2024 19:03
dav3r
dav3r approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Do you have a checkbox item somewhere to delete /cdm/tanium_hostname from the SSM parameter store when it is no longer needed?

@jsf9k
Copy link
Member Author

jsf9k commented May 20, 2024

👍

Do you have a checkbox item somewhere to delete /cdm/tanium_hostname from the SSM parameter store when it is no longer needed?

I do now. Please see cisagov/cool-sharedservices-cdm#48.

@jsf9k jsf9k enabled auto-merge May 20, 2024 14:16
@jsf9k jsf9k merged commit 8c8cd88 into develop May 20, 2024
9 checks passed
@jsf9k jsf9k deleted the improvement/remove-tanium branch May 20, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

Labels
ansible Pull requests that update Ansible code breaking change This issue or pull request involves changes to existing functionality dependencies Pull requests that update a dependency file improvement This issue or pull request will add or improve functionality, maintainability, or ease of use security This issue or pull request addresses a security issue terraform Pull requests that update Terraform code version bump This issue or pull request increments the version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Tanium
3 participants
@jsf9k @dav3r @dv4harr10