Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2737: Members csv report - [MEOWARD] #3083
#2737: Members csv report - [MEOWARD] #3083
Changes from 36 commits
b0dc18c
2265b70
48ae7f4
1e43974
9ac8a3e
10c0187
b7f3f08
174d217
bf585be
0ca0602
78e0316
854df71
17acb66
ae6ecab
e915937
9374d91
7075b72
3b378d3
1c0f99e
5f5bc4f
a236583
c98a96e
f3e1826
121d218
dc12efe
384a967
b679108
252fa2e
43bc969
20c0813
908e06c
b791daf
4ab526c
981cdb3
3f8db08
4eb5431
859e8b3
e813791
e2bd982
4013815
958e010
2b5a5fe
d354f04
a7fd3b9
a77eb59
2f93ad9
f05148f
e91526e
62f0205
c4a2748
d0f0d56
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Q) Is this style of return readable? The else isn't needed here, but I was wondering if this makes it easier to parse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks readable to me. Is there an instance where the PortfolioPermissions would be "None". I don't see it option listed, but its good to prevent errors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from the AC:
Whether the member can manage other members in the organization. Tentatively, I think the options as we currently understand would be : None, Viewer, Manager
We don't have a enum value of "None", its just a catch-all label for neither viewer nor manager