#2728: domain manager page updates [BOB] #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🥳 Successfully deployed to developer sandbox bob. |
dave-kennedy-ecs
changed the title
|
🥳 Successfully deployed to developer sandbox bob. |
therealslimhsiehdy
approved these changes
Nov 15, 2024
| <p> | ||
| Domain managers can update all information related to a domain within the | ||
| .gov registrar, including security email and DNS name servers. | ||
| .gov registrar, including contact details, senior official, security email, and DNS name servers. |
There was a problem hiding this comment.
Comment: Looking at the copy from the Figma, the bullet point with "All domain managers will be notified when updates are made to this domain." needs to be removed.
| response = self.client.get(reverse("domain-users", kwargs={"pk": self.domain.id})) | ||
| self.assertContains(response, "Domain managers") | ||
| self.assertContains(response, "Add a domain manager") | ||
| # assert that the non-portfolio view contains Role column and doesn't contain Admin |
There was a problem hiding this comment.
Comment: Update comment to that this is the portfolio view and that it doesn't contain Role column and does contain Admin tag
|
🥳 Successfully deployed to developer sandbox bob. |
|
🥳 Successfully deployed to developer sandbox bob. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #2728
Changes
Context for reviewers
Setup
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Validated user-facing changes as a developer
Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
References
Screenshots