Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2771 + #3015: Create requesting entity page - [MEOWARD] #2973
#2771 + #3015: Create requesting entity page - [MEOWARD] #2973
Changes from 49 commits
e04337f
b3e9096
65f1e62
860f8f4
888d77b
514cd8a
263ec02
086d197
5b629bd
ab7a6ac
0374efb
939b11e
150a59c
5cb3298
bde6c5e
5e23ebe
d9ec108
87d51c1
178d127
14bfeb7
738ff0f
d44bcad
934d06d
0933fe4
9531076
7e2e75d
d0aff60
b09e0ca
bc8789b
ee71ba4
b3faa00
a94a5b2
c465b7f
dfb59a6
4f1febf
bb9cb52
98842c1
603e2eb
b01e707
f0ba596
5109384
ba61ec8
1d34598
83720c3
b05a62e
7cdfb7a
c59289d
7141eae
a1d37ee
706dd4f
cf0fec1
e4c15ee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change before merging: add an error message here see response to you question here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks didn't catch that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change before merging Why don't these errors match the ones you have above in the field definitions? If the others aren't triggering due to the setup, they should be removed to avoid confusion and the content copied here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Just old content that evaded me I guess, the errors that get thrown are the ones in clean as these are all "optional"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Why aren't we using error definitions on the form fields instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion Key info on your return values should exist in the docstring for the function.
example to shorten it here
"""
Determines the initial checked state of the form, returning True (checked) if the requesting entity is a suborganization, and False if it is a portfolio. Returns None if neither condition is met.
"""