Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Federal Agency and SO tables, and fill both #2399

Closed
5 tasks done
abroddrick opened this issue Jul 1, 2024 · 3 comments · Fixed by #2507
Closed
5 tasks done

Update Federal Agency and SO tables, and fill both #2399

abroddrick opened this issue Jul 1, 2024 · 3 comments · Fixed by #2507
Assignees
Labels
dev issue is for the dev team

Comments

@abroddrick
Copy link
Contributor

abroddrick commented Jul 1, 2024

Issue description

Now that we have the complete list of senior officials that was made in #2097, we can make a script to populate this table. We will eventually be populating the organizations/porfolio via another script so it is worth while for use to also store federal agency along with the AO. When a federal portfolio is being manually made in django admin, having a link between federal agency and SO (that can be null) would allow us to auto populate the SO value based on the the agency. For instance, if a user was making a portfolio for DHS, they would select the DHS agency name and then the SO would autofill on their screen. That said, while we make this script let's also make sure that the agency foreign key field gets properly added and filled as well.

Acceptance criteria

  • modify the senior official table to include a federal agency foreign key field that can be null (this is to allow us to add state/other orgs later without them needing to be federal orgs)
  • modify the federal agency table such that it has a field "initials" and a boolean field "is FCEB". "is FCEB" should default to false.
  • the script reads the file linked in Finalize list of Senior Officials (SOs) for federal agencies #2097 and fills the SO table with the correct link to it's corresponding federal agency and fills all the name/ email and role values. (note "title" on the SO table correlates to "role/position" in the csv)
  • This script (or a separate one) should also update the federal agency table with the values for "initials" and for "is FCEB" (note "is FCEB" should correlate to the status column and is true where that status is filled in.)
  • Test this on litterbox

Additional context

No response

Links to other issues

relates to #2300

@abroddrick abroddrick added the dev issue is for the dev team label Jul 1, 2024
@abroddrick
Copy link
Contributor Author

abroddrick commented Jul 1, 2024

Tentatively adding to sprint 50 as this is continues on with the org model but doesn't conflict with the user interface changes and is low risk for merge conflicts

@PaulKuykendall PaulKuykendall moved this from 👶 New to 🎯 Ready in .gov Product Board Jul 1, 2024
@abroddrick
Copy link
Contributor Author

@vickyszuchin don't let people pull this one in while I'm gone. There needs to be some edits here based on a convo about adding more fields to this same table

@abroddrick
Copy link
Contributor Author

Adding refinement as the AC here needs to change, adding myself so I remember to update it tomorrow. @zandercymatics I will add you back when I am done.

@katypies katypies changed the title Script to fill Senior official table Update Federal Agency and SO tables, and fill both Jul 22, 2024
@vickyszuchin vickyszuchin moved this from 🎯 Ready to 🔖 Planned in .gov Product Board Jul 23, 2024
@zandercymatics zandercymatics moved this from 🔖 Planned to 👀 In review in .gov Product Board Jul 29, 2024
zandercymatics added a commit that referenced this issue Aug 7, 2024
…cial

Ticket #2399: Fill senior official table and update SO tables [MIGRATIONS]
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in .gov Product Board Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment