Skip to content

Commit

Permalink
Merge pull request #1129 from cisagov/za/1096-update-domain-button-text
Browse files Browse the repository at this point in the history
Ticket #1096: Small content changes for Domain buttons
  • Loading branch information
zandercymatics authored Oct 10, 2023
2 parents cc42c23 + 3c33b07 commit f1751b1
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 12 deletions.
3 changes: 2 additions & 1 deletion src/registrar/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,8 @@ def do_get_status(self, request, obj):
else:
self.message_user(
request,
("Domain statuses are %s" ". Thanks!") % statuses,
f"The registry statuses are {statuses}. "
"These statuses are from the provider of the .gov registry.",
)
return HttpResponseRedirect(".")

Expand Down
1 change: 0 additions & 1 deletion src/registrar/models/domain.py
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,6 @@ def map_epp_contact_to_public_contact(

if not isinstance(contact, eppInfo.InfoContactResultData):
raise ContactError("Contact must be of type InfoContactResultData")

auth_info = contact.auth_info
postal_info = contact.postal_info
addr = postal_info.addr
Expand Down
6 changes: 3 additions & 3 deletions src/registrar/templates/django/admin/domain_change_form.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
{% elif original.state == original.State.ON_HOLD %}
<input type="submit" value="Remove hold" name="_remove_client_hold">
{% endif %}
<input id="manageDomainSubmitButton" type="submit" value="Manage Domain" name="_edit_domain">
<input type="submit" value="get status" name="_get_status">
<input id="manageDomainSubmitButton" type="submit" value="Manage domain" name="_edit_domain">
<input type="submit" value="Get registry status" name="_get_status">
{% if original.state != original.State.DELETED %}
<input type="submit" value="Delete Domain in Registry" name="_delete_domain">
<input type="submit" value="Delete domain in registry" name="_delete_domain">
{% endif %}
</div>
{{ block.super }}
Expand Down
14 changes: 7 additions & 7 deletions src/registrar/tests/test_admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,12 @@ def test_deletion_is_successful(self):
)
self.assertEqual(response.status_code, 200)
self.assertContains(response, domain.name)
self.assertContains(response, "Delete Domain in Registry")
self.assertContains(response, "Delete domain in registry")

# Test the info dialog
request = self.factory.post(
"/admin/registrar/domain/{}/change/".format(domain.pk),
{"_delete_domain": "Delete Domain in Registry", "name": domain.name},
{"_delete_domain": "Delete domain in registry", "name": domain.name},
follow=True,
)
request.user = self.client
Expand Down Expand Up @@ -149,12 +149,12 @@ def test_deletion_ready_fsm_failure(self):
)
self.assertEqual(response.status_code, 200)
self.assertContains(response, domain.name)
self.assertContains(response, "Delete Domain in Registry")
self.assertContains(response, "Delete domain in registry")

# Test the error
request = self.factory.post(
"/admin/registrar/domain/{}/change/".format(domain.pk),
{"_delete_domain": "Delete Domain in Registry", "name": domain.name},
{"_delete_domain": "Delete domain in registry", "name": domain.name},
follow=True,
)
request.user = self.client
Expand Down Expand Up @@ -194,12 +194,12 @@ def test_analyst_deletes_domain_idempotent(self):
)
self.assertEqual(response.status_code, 200)
self.assertContains(response, domain.name)
self.assertContains(response, "Delete Domain in Registry")
self.assertContains(response, "Delete domain in registry")

# Test the info dialog
request = self.factory.post(
"/admin/registrar/domain/{}/change/".format(domain.pk),
{"_delete_domain": "Delete Domain in Registry", "name": domain.name},
{"_delete_domain": "Delete domain in registry", "name": domain.name},
follow=True,
)
request.user = self.client
Expand All @@ -221,7 +221,7 @@ def test_analyst_deletes_domain_idempotent(self):
# Test the info dialog
request = self.factory.post(
"/admin/registrar/domain/{}/change/".format(domain.pk),
{"_delete_domain": "Delete Domain in Registry", "name": domain.name},
{"_delete_domain": "Delete domain in registry", "name": domain.name},
follow=True,
)
request.user = self.client
Expand Down

0 comments on commit f1751b1

Please sign in to comment.