Skip to content

Commit

Permalink
Fix unit test
Browse files Browse the repository at this point in the history
  • Loading branch information
zandercymatics committed Nov 1, 2024
1 parent cf0fec1 commit e4c15ee
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions src/registrar/forms/domain_request_wizard.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,13 +115,13 @@ def clean(self):
if is_requesting_new_suborganization:
# Validate custom suborganization fields
if not cleaned_data.get("requested_suborganization"):
self.add_error("requested_suborganization", "Requested suborganization is required")
self.add_error("requested_suborganization", "Requested suborganization is required.")
if not cleaned_data.get("suborganization_city"):
self.add_error("suborganization_city", "City is required")
self.add_error("suborganization_city", "City is required.")
if not cleaned_data.get("suborganization_state_territory"):
self.add_error("suborganization_state_territory", "State, territory, or military post is required")
self.add_error("suborganization_state_territory", "State, territory, or military post is required.")
elif not suborganization:
self.add_error("sub_organization", "Select a suborganization.")
self.add_error("sub_organization", "Suborganization is required.")

return cleaned_data

Expand Down
8 changes: 4 additions & 4 deletions src/registrar/tests/test_views_portfolio.py
Original file line number Diff line number Diff line change
Expand Up @@ -1788,15 +1788,15 @@ def test_requesting_entity_page_errors(self):

response = form.submit()
self.app.set_cookie(settings.SESSION_COOKIE_NAME, session_id)
self.assertContains(response, "Select a suborganization.", status_code=200)
self.assertContains(response, "Suborganization is required.", status_code=200)

# Test missing custom suborganization details
form["portfolio_requesting_entity-is_requesting_new_suborganization"] = True
response = form.submit()
self.app.set_cookie(settings.SESSION_COOKIE_NAME, session_id)
self.assertContains(response, "Enter details for your organization name.", status_code=200)
self.assertContains(response, "Enter details for your city.", status_code=200)
self.assertContains(response, "Enter details for your state or territory.", status_code=200)
self.assertContains(response, "Requested suborganization is required.", status_code=200)
self.assertContains(response, "City is required.", status_code=200)
self.assertContains(response, "State, territory, or military post is required.", status_code=200)

@override_flag("organization_feature", active=True)
@override_flag("organization_requests", active=True)
Expand Down

0 comments on commit e4c15ee

Please sign in to comment.