Skip to content

Commit

Permalink
Merge pull request #2703 from cisagov/za/fix-additional-allowed-email…
Browse files Browse the repository at this point in the history
…s-bug

Fix bug with fixtures on `additional_allowed_emails` adding strings instead of AllowedEmail objects
  • Loading branch information
zandercymatics authored Sep 3, 2024
2 parents 54e6ce2 + ff00d56 commit bf2079a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/registrar/fixtures_users.py
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ def load_allowed_emails(cls, users, additional_emails):
logger.warning(f"Could not add email to whitelist for {first_name} {last_name}.")

# Load additional emails
allowed_emails.extend(additional_emails)
allowed_emails.extend([AllowedEmail(email=email) for email in additional_emails])

if allowed_emails:
AllowedEmail.objects.bulk_create(allowed_emails)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<p>This table is an email whitelist for <strong>non-production</strong> environments.</p>
<p>This table is an email allow list for <strong>non-production</strong> environments.</p>
<p>
If an email is sent out and the email does not exist within this table (or is not a subset of it),
then no email will be sent.
Expand Down

0 comments on commit bf2079a

Please sign in to comment.