-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable trace functionality and enable HSTS headers in Apache #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
hacktoberfest-accepted
Pull request that should count toward Hacktoberfest participation
security
This issue or pull request addresses a security issue
labels
Oct 26, 2023
jsf9k
added
the
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
label
Oct 26, 2023
…server This is being done for testing and this change can be reverted once cisagov/ansible-role-freeipa-server#69 is merged.
We want to disable trace functionality and enable HSTS headers.
jsf9k
force-pushed
the
feature/disable-trace-and-enable-hsts
branch
from
October 30, 2023 14:32
23ae371
to
2ebbce3
Compare
dav3r
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strong work 👍
dv4harr10
approved these changes
Oct 31, 2023
…freeipa-server" This reverts commit ad1db20. This change can be reverted now that cisagov/ansible-role-freeipa-server#69 has been approved and merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
hacktoberfest-accepted
Pull request that should count toward Hacktoberfest participation
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
security
This issue or pull request addresses a security issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request leverages some recent changes in cisagov/ansible-role-freeipa-server in order to make the following changes in the configuration of the Apache server that is in front of FreeIPA:
💭 Motivation and context
The security folks are concerned that trace functionality is enabled on the Apache server that sits in front of FreeIPA. This is despite this note in the Apache documentation.
The security folks are also concerned that the same Apache server is not returning HSTS headers.
See cisagov/cool-system-internal#135 and cisagov/cool-system-internal#136 for more details.
🧪 Testing
All automated tests pass. I also built a new FreeIPA AMI for COOL staging that included these changes and verified that it functioned as expected.
📷 Screenshots
Here you can see on the left that:
Strict-Transport-Security
HTML header is present in the response from the web server.TRACE
HTTP method request, indicating that the method is disallowed.✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist