Fix broken Python packaging #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav3r
approved these changes
Apr 15, 2022
Since this Python module doesn't use a standard src-layout, setuptools gets confused and is unable to locate the packages to be included. Since this "Python module" is really just a collection of scripts, we can tell setuptools to restrict itself to project_setup/scripts. This is yet another reason why #33 is a good idea.
jsf9k
force-pushed
the
bugfix/fix-broken-python-packaging
branch
from
4e2056c to
e28489e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds a
package_dirattribute tosetup.pyin order to address broken Python packaging.Note that this pull request cannot be merged until after #70 is approved and merged.
💭 Motivation and context
Since this Python module doesn't use a standard src-layout,
setuptoolsgets confused and is unable to locate the packages to be included in the module. Since this "Python module" is really just a collection of scripts located in theproject_setup/scriptsdirectory, we can tellsetuptoolsto restrict itself to that directory.This is yet another reason why #33 is a good idea.
🧪 Testing
All automated tests pass. I have used these changes to successfully create a Python virtual environment in which this module is installed. This was not possible before these changes.
✅ Pre-approval checklist