Fix report title lookup

Also added SSG IT page inclusion based on Sector.
cisagov · Jan 2, 2025 · 79fdf3d · 79fdf3d
1 parent db843e6
commit 79fdf3d
Show file tree

Hide file tree

Showing 20 changed files with 124 additions and 65 deletions.
diff --git a/CSETWebApi/CSETWeb_Api/CSETWebCore.Business/Maturity/CpgBusiness.cs b/CSETWebApi/CSETWeb_Api/CSETWebCore.Business/Maturity/CpgBusiness.cs
@@ -150,6 +150,15 @@ private List<Series> InitializeSeries()
             }
 
 
+            // INFORMATION TECHNOLOGY (IT)
+            var itSectors = new List<int>() { 13, 28 };
+            if ((itSectors.Contains(demographics?.SectorId ?? -1))
+                || itSectors.Contains(ddSector?.IntValue ?? -1))
+            {
+                return 20;
+            }
+
+
             return null;
         }
     }

diff --git a/CSETWebNg/src/app/reports/cmmc2/cmmc2-comments-marked/cmmc2-comments-marked.component.ts b/CSETWebNg/src/app/reports/cmmc2/cmmc2-comments-marked/cmmc2-comments-marked.component.ts
@@ -26,6 +26,7 @@ import { Title } from '@angular/platform-browser';
 import { ConfigService } from '../../../services/config.service';
 import { MaturityService } from '../../../services/maturity.service';
 import { QuestionsService } from '../../../services/questions.service';
+import { TranslocoService } from '@jsverse/transloco';
 
 @Component({
   selector: 'app-cmmc2-comments-marked',
@@ -45,13 +46,18 @@ export class Cmmc2CommentsMarkedComponent implements OnInit {
     public configSvc: ConfigService,
     private titleService: Title,
     private maturitySvc: MaturityService,
-    public questionsSvc: QuestionsService
+    public questionsSvc: QuestionsService,
+    public tSvc: TranslocoService
   ) { }
 
   ngOnInit() {
+    this.tSvc.selectTranslate('comments and marked for review', {}, { scope: 'reports' })
+      .subscribe(title =>
+        this.titleService.setTitle(title + ' - ' + this.configSvc.behaviors.defaultTitle));
+
     this.loading = true;
     this.keyToCategory = this.maturitySvc.keyToCategory;
-    this.titleService.setTitle("CMMC 2.0 Comments and Marked for Review - " + this.configSvc.behaviors.defaultTitle);
+
 
     this.maturitySvc.getCmmcReportData().subscribe(
       (r: any) => {

diff --git a/CSETWebNg/src/app/reports/cmmc2/cmmc2-scorecard-report/cmmc2-scorecard-report.component.ts b/CSETWebNg/src/app/reports/cmmc2/cmmc2-scorecard-report/cmmc2-scorecard-report.component.ts
@@ -1,6 +1,10 @@
 import { Component, Input } from '@angular/core';
 import { AssessmentService } from '../../../services/assessment.service';
 import { MaturityService } from '../../../services/maturity.service';
+import { TranslocoService } from '@jsverse/transloco';
+import { TypescriptDefaultsService } from '@ngstack/code-editor';
+import { Title } from '@angular/platform-browser';
+import { ConfigService } from '../../../services/config.service';
 
 @Component({
   selector: 'app-cmmc2-scorecard-report',
@@ -18,18 +22,26 @@ export class Cmmc2ScorecardReportComponent {
 
   targetLevel: number;
 
-/**
- * 
- */
+  /**
+   * 
+   */
   constructor(
     public assessSvc: AssessmentService,
-    public maturitySvc: MaturityService
+    public maturitySvc: MaturityService,
+    public tSvc: TranslocoService,
+    public titleService: Title,
+    public configSvc: ConfigService
   ) { }
 
   /**
    * 
    */
   ngOnInit(): void {
+    this.tSvc.selectTranslate('scorecard report', {}, { scope: 'reports' })
+      .subscribe(title => {
+        this.titleService.setTitle(title + ' - ' + this.configSvc.behaviors.defaultTitle)
+      });
+
     this.maturitySvc.getCmmcReportData().subscribe((r: any) => {
       const info = r.reportData.information;
       this.assessmentDate = info.assessment_Date;

diff --git a/CSETWebNg/src/app/reports/cmmc2/executive-cmmc2/executive-cmmc2.component.ts b/CSETWebNg/src/app/reports/cmmc2/executive-cmmc2/executive-cmmc2.component.ts
@@ -28,6 +28,7 @@ import Chart from 'chart.js/auto';
 import { ChartService } from '../../../services/chart.service';
 import { MaturityService } from '../../../services/maturity.service';
 import { ConfigService } from '../../../services/config.service';
+import { TranslocoService } from '@jsverse/transloco';
 
 
 @Component({
@@ -62,7 +63,8 @@ export class ExecutiveCMMC2Component implements OnInit, AfterViewInit {
     public chartSvc: ChartService,
     private maturitySvc: MaturityService,
     private titleService: Title,
-    public configSvc: ConfigService
+    public configSvc: ConfigService,
+    public tSvc: TranslocoService
   ) {
 
   }
@@ -71,7 +73,10 @@ export class ExecutiveCMMC2Component implements OnInit, AfterViewInit {
    *
    */
   ngOnInit() {
-    this.titleService.setTitle("Executive Summary - " + this.configSvc.behaviors.defaultTitle);
+
+    this.tSvc.selectTranslate('executive summary', {}, { scope: 'reports' })
+      .subscribe(title =>
+        this.titleService.setTitle(title + ' - ' + this.configSvc.behaviors.defaultTitle));
 
     this.targetLevel = 0;
     this.reportSvc.getReport('executivematurity').subscribe(

diff --git a/CSETWebNg/src/app/reports/commentsmfr/commentsmfr.component.ts b/CSETWebNg/src/app/reports/commentsmfr/commentsmfr.component.ts
@@ -37,7 +37,6 @@ import { TranslocoService } from '@jsverse/transloco';
   styleUrls: ['../reports.scss', '../acet-reports.scss']
 })
 export class CommentsMfrComponent implements OnInit {
-  translationTabTitle: any;
   response: any = null;
   remarks: string;
 
@@ -66,11 +65,11 @@ export class CommentsMfrComponent implements OnInit {
    */
   ngOnInit(): void {
     this.loading = true;
-    
-    this.translationTabTitle = this.tSvc.selectTranslate('reports.core.rra.cmfr.report title')
-    .subscribe(value =>
-      this.titleService.setTitle(this.tSvc.translate('reports.core.rra.cmfr.report title') + ' - ' + this.configSvc.behaviors.defaultTitle));
-  
+
+    this.tSvc.selectTranslate('comments and marked for review', {}, { scope: 'reports' })
+      .subscribe(title =>
+        this.titleService.setTitle(title + ' - ' + this.configSvc.behaviors.defaultTitle));
+
 
     this.maturitySvc.getCommentsMarked().subscribe(
       (r: any) => {

diff --git a/CSETWebNg/src/app/reports/cpg/cpg-deficiency/cpg-deficiency.component.ts b/CSETWebNg/src/app/reports/cpg/cpg-deficiency/cpg-deficiency.component.ts
@@ -76,7 +76,10 @@ export class CpgDeficiencyComponent implements OnInit {
   ngOnInit(): void {
     this.loading = true;
 
-    this.titleSvc.setTitle(this.tSvc.translate('reports.core.cpg.deficiency.cpg deficiency') + " - " + this.configSvc.behaviors.defaultTitle);
+    this.tSvc.selectTranslate('core.cpg.deficiency.cpg deficiency', {}, {scope: 'reports'})
+      .subscribe(title => {
+        this.titleSvc.setTitle(title + ' - ' + this.configSvc.behaviors.defaultTitle)
+      });
 
     // make sure that the assessSvc has the assessment loaded so that we can determine any SSG model applicable
     this.assessSvc.getAssessmentDetail().subscribe((assessmentDetail: any) => {

diff --git a/CSETWebNg/src/app/reports/cpg/cpg-report/cpg-report.component.ts b/CSETWebNg/src/app/reports/cpg/cpg-report/cpg-report.component.ts
@@ -35,10 +35,8 @@ import { TranslocoService } from '@jsverse/transloco';
   styleUrls: ['./cpg-report.component.scss', '../../reports.scss']
 })
 export class CpgReportComponent implements OnInit {
-  translationTabTitle: any;
-
   loading = false;
-  
+
   assessmentName: string;
   assessmentDate: string;
   assessorName: string;
@@ -66,9 +64,9 @@ export class CpgReportComponent implements OnInit {
    * 
    */
   ngOnInit(): void {
-    this.translationTabTitle = this.tSvc.selectTranslate('reports.core.cpg.report.cpg report')
-      .subscribe(value =>
-        this.titleSvc.setTitle(this.tSvc.translate('reports.core.cpg.report.cpg report') + ' - ' + this.configSvc.behaviors.defaultTitle));
+    this.tSvc.selectTranslate('core.cpg.report.cpg report', {}, { scope: 'reports' })
+      .subscribe(title =>
+        this.titleSvc.setTitle(title + ' - ' + this.configSvc.behaviors.defaultTitle));
 
     this.assessSvc.getAssessmentDetail().subscribe((assessmentDetail: any) => {
       this.assessmentName = assessmentDetail.assessmentName;

diff --git a/CSETWebNg/src/app/reports/executive-summary/executive-summary.component.ts b/CSETWebNg/src/app/reports/executive-summary/executive-summary.component.ts
@@ -45,7 +45,6 @@ export class ExecutiveSummaryComponent implements OnInit {
   chartStandardsSummary: Chart;
   //canvasStandardResultsByCategory: Chart;
   responseResultsByCategory: any;
-  translationSub: any; 
 
   // Charts for Components
   componentCount = 0;
@@ -69,17 +68,16 @@ export class ExecutiveSummaryComponent implements OnInit {
     public acetSvc: ACETService,
     private assessmentSvc: AssessmentService,
     public configSvc: ConfigService,
-    public tSvc: TranslocoService, 
-    private translocoService: TranslocoService
+    public tSvc: TranslocoService,
   ) { }
 
   ngOnInit() {
 
     this.titleService.setTitle("Executive Summary - " + this.configSvc.behaviors.defaultTitle);
 
-    this.translationSub = this.translocoService.selectTranslate('')
-        .subscribe(value => 
-        this.titleService.setTitle(this.tSvc.translate('reports.core.executive summary.report title') + ' - ' + this.configSvc.behaviors.defaultTitle));
+    this.tSvc.selectTranslate('core.executive summary.report title', {}, { scope: 'reports' })
+      .subscribe(title =>
+        this.titleService.setTitle(title + ' - ' + this.configSvc.behaviors.defaultTitle));
 
     this.reportSvc.getReport('executive').subscribe(
       (r: any) => {
@@ -121,9 +119,4 @@ export class ExecutiveSummaryComponent implements OnInit {
   usesRAC() {
     return !!this.responseResultsByCategory?.dataSets.find(e => e.label === 'RAC');
   }
-
-  ngOnDestroy() {
-    this.translationSub.unsubscribe()
-}
-
 }
diff --git a/CSETWebNg/src/app/reports/physical-summary/physical-summary.component.ts b/CSETWebNg/src/app/reports/physical-summary/physical-summary.component.ts
@@ -64,9 +64,9 @@ export class PhysicalSummaryComponent implements OnInit, AfterViewInit {
   ) { }
 
   ngOnInit() {
-    this.translationSub = this.tSvc.selectTranslate('reports.core.physical summary.report title')
-      .subscribe(value =>
-        this.titleService.setTitle(this.tSvc.translate('reports.core.physical summary.report title') + ' - ' + this.configSvc.behaviors.defaultTitle));
+    this.tSvc.selectTranslate('core.physical summary.report title', {}, { scope: 'reports' })
+      .subscribe(title =>
+        this.titleService.setTitle(title + ' - ' + this.configSvc.behaviors.defaultTitle));
 
     this.reportSvc.getReport('physicalsummary').subscribe(
       (r: any) => {

diff --git a/CSETWebNg/src/app/reports/rra/rra-deficiency/rra-deficiency.component.ts b/CSETWebNg/src/app/reports/rra/rra-deficiency/rra-deficiency.component.ts
@@ -37,8 +37,6 @@ import { TranslocoService } from '@jsverse/transloco';
   styleUrls: ['../../reports.scss', '../../acet-reports.scss']
 })
 export class RraDeficiencyComponent implements OnInit {
-  translationTabTitle: any;
-
   response: any;
 
   loading: boolean = false;
@@ -65,9 +63,9 @@ export class RraDeficiencyComponent implements OnInit {
   ngOnInit() {
     this.loading = true;
 
-    this.translationTabTitle = this.tSvc.selectTranslate('reports.core.rra.rra deficiency report')
-      .subscribe(value =>
-        this.titleService.setTitle(this.tSvc.translate('reports.core.rra.rra deficiency report') + ' - ' + this.configSvc.behaviors.defaultTitle));
+    this.tSvc.selectTranslate('core.rra.rra deficiency report', {}, {scope: 'reports'})
+      .subscribe(title =>
+        this.titleService.setTitle(title + ' - ' + this.configSvc.behaviors.defaultTitle));
 
 
     this.maturitySvc.getMaturityDeficiency("RRA").subscribe(

diff --git a/CSETWebNg/src/app/reports/rra/rra-report/rra-report.component.ts b/CSETWebNg/src/app/reports/rra/rra-report/rra-report.component.ts
@@ -38,7 +38,6 @@ import { TranslocoService } from '@jsverse/transloco';
 })
 export class RraReportComponent implements OnInit {
   response: any;
-  translationTabTitle: any;
 
   overallScoreDisplay: string;
   standardBasedScore: number;
@@ -131,9 +130,9 @@ export class RraReportComponent implements OnInit {
       error => console.log('Main RRA report load Error: ' + (<Error>error).message)
     );
 
-    this.translationTabTitle = this.tSvc.selectTranslate('reports.core.rra.tab title')
-      .subscribe(value =>
-        this.titleService.setTitle(this.tSvc.translate('reports.core.rra.tab title') + ' - ' + this.configSvc.behaviors.defaultTitle));
+    this.tSvc.selectTranslate('core.rra.tab title', {}, { scope: 'reports' })
+      .subscribe(title =>
+        this.titleService.setTitle(title + ' - ' + this.configSvc.behaviors.defaultTitle));
   }
 
   /**

diff --git a/CSETWebNg/src/app/reports/sd-owner/sd-owner-comments/sd-owner-comments-mfr.component.ts b/CSETWebNg/src/app/reports/sd-owner/sd-owner-comments/sd-owner-comments-mfr.component.ts
@@ -38,7 +38,6 @@ import { Title } from '@angular/platform-browser';
 })
 
 export class SdOwnerCommentsMfrComponent {
-  translationTabTitle: any;
   response: any = null;
   remarks: string;
   loading: boolean = false;
@@ -59,9 +58,9 @@ export class SdOwnerCommentsMfrComponent {
   ngOnInit(): void {
     this.loading = true;
 
-    this.translationTabTitle = this.tSvc.selectTranslate('reports.core.rra.cmfr.report title')
-    .subscribe(value =>
-      this.titleService.setTitle(this.tSvc.translate('reports.core.rra.cmfr.report title') + ' - ' + this.configSvc.behaviors.defaultTitle));
+    this.tSvc.selectTranslate('core.rra.cmfr.report title', {}, {scope: 'reports'})
+    .subscribe(title =>
+      this.titleService.setTitle(title + ' - ' + this.configSvc.behaviors.defaultTitle));
 
 
     this.maturitySvc.getCommentsMarked().subscribe(

diff --git a/CSETWebNg/src/app/reports/securityplan/securityplan.component.ts b/CSETWebNg/src/app/reports/securityplan/securityplan.component.ts
@@ -59,17 +59,16 @@ export class SecurityplanComponent implements OnInit {
     private assessmentSvc: AssessmentService,
     private sanitizer: DomSanitizer,
     public tSvc: TranslocoService,
-    private translocoService: TranslocoService
   ) { }
 
   /**
    *
    */
   ngOnInit() {
-
-    this.translationSub = this.translocoService.selectTranslate('reports.core.security plan.report title')
-      .subscribe(value =>
-        this.titleService.setTitle(this.tSvc.translate('reports.core.security plan.report title') + ' - ' + this.configSvc.behaviors.defaultTitle));
+    this.tSvc.selectTranslate('core.security plan.report title', {}, { scope: 'reports' })
+      .subscribe(title => {
+        this.titleService.setTitle(title + ' - ' + this.configSvc.behaviors.defaultTitle)
+      });
 
     this.reportSvc.getReport('securityplan').subscribe(
       (r: any) => {

diff --git a/CSETWebNg/src/app/reports/site-detail/site-detail.component.ts b/CSETWebNg/src/app/reports/site-detail/site-detail.component.ts
@@ -40,7 +40,6 @@ import { TranslocoService } from '@jsverse/transloco';
   styleUrls: ['../reports.scss']
 })
 export class SiteDetailComponent implements OnInit {
-  translationSub: any;
   response: any = null;
   chartStandardsSummary: Chart;
   responseResultsByCategory: any;
@@ -81,9 +80,9 @@ export class SiteDetailComponent implements OnInit {
   ) { }
 
   ngOnInit() {
-    this.translationSub = this.tSvc.selectTranslate('reports.core.site detail report.report title')
-      .subscribe(value =>
-        this.titleService.setTitle(this.tSvc.translate('reports.core.site detail report.report title') + ' - ' + this.configSvc.behaviors.defaultTitle));
+    this.tSvc.selectTranslate('core.site detail report.report title', {}, {scope: 'reports'})
+      .subscribe(title =>
+        this.titleService.setTitle(title + ' - ' + this.configSvc.behaviors.defaultTitle));
 
     this.reportSvc.getReport('detail').subscribe(
       (r: any) => {
@@ -223,8 +222,4 @@ export class SiteDetailComponent implements OnInit {
   usesRAC() {
     return !!this.responseResultsByCategory?.dataSets.find(e => e.label === 'RAC');
   }
-
-  ngOnDestroy() {
-    this.translationSub.unsubscribe()
-  }
 }
diff --git a/CSETWebNg/src/app/reports/site-summary/site-summary.component.ts b/CSETWebNg/src/app/reports/site-summary/site-summary.component.ts
@@ -87,9 +87,9 @@ export class SiteSummaryComponent implements OnInit, AfterViewInit {
   ) { }
 
   ngOnInit() {
-    this.translationSub = this.tSvc.selectTranslate('reports.core.site summary.report title')
-      .subscribe(value =>
-        this.titleService.setTitle(this.tSvc.translate('reports.core.site summary.report title') + ' - ' + this.configSvc.behaviors.defaultTitle));
+    this.tSvc.selectTranslate('core.site summary.report title', {}, {scope: 'reports'})
+      .subscribe(title =>
+        this.titleService.setTitle(title + ' - ' + this.configSvc.behaviors.defaultTitle));
 
     this.isCmmc = this.maturitySvc.maturityModelIsCMMC();
     this.reportSvc.getReport('sitesummary').subscribe(

diff --git a/CSETWebNg/src/app/services/ssg.service.ts b/CSETWebNg/src/app/services/ssg.service.ts
@@ -54,6 +54,10 @@ export class SsgService {
       return 'chemical';
     }
 
+    if ([13, 28].includes(s)) {
+      return 'it';
+    }
+
     return 'other';
   }
 
@@ -71,6 +75,11 @@ export class SsgService {
     if ([1, 19].includes(s)) {
       return 18; // chemical
     }
+
+
+    if ([13, 28].includes(s)) {
+      return 20; // I.T.
+    }
     return null;
   }
 

diff --git a/CSETWebNg/src/assets/i18n/en.json b/CSETWebNg/src/assets/i18n/en.json
@@ -308,6 +308,7 @@
     "answer buttons": "Answer Buttons",
     "ssg": {
       "chemical": "Chemical Sector Goals",
+      "it": "Information Technology Goals",
       "other": "Other Sector Goals"
     }
   },