Add anti-disconnect jazz from cisagov/pca-gophish-composition-packer #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added this to the Assessment Environment MVP for RPT acceptance testing milestone
Copying the file over and then editing it remotely is much more complicated if you're trying to maintain idempotence.
dav3r
approved these changes
Mar 12, 2020
felddy
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request makes the following changes:
💭 Motivation and Context
When we were testing VNC via the Guacamole server in ENV0, we found that the connections were still being randomly disconnected if we didn't include these fixes.
🧪 Testing
These changes have been tested in the COOL in ENV0.
🚥 Types of Changes
✅ Checklist