Use DEB822 repo for all Debian platforms except for Buster #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kali recently updated to a version of apt that no longer provides the deprecated apt-key binary, so we cannot use ansible.builtin.apt_key to get the official Docker repo GPG key. We may as well upgrade to a DEB822 repo while we're at it.
The latter is more specific and better connotes what the variable contains.
This will allow us to treat Kali as less of a special case.
This will allow us to stop treating Kali as a special case.
jsf9k
added
the
improvement
All platforms we support use systemd.
jsf9k
force-pushed
the
improvement/use-deb822-repo-for-everything-but-debian-buster
branch
from
238326e to
b2b46ee
Compare
This task should only run if the ansible.builtin.deb822_repository task actually changes anything.
jsf9k
force-pushed
the
improvement/use-deb822-repo-for-everything-but-debian-buster
branch
from
cdd927e to
78d2f03
Compare
|
The Fedora 40 and 41 tests are failing because of fedora-cloud/docker-brew-fedora#117. See also this RedHat Bugzilla issue. |
dav3r
approved these changes
Dec 30, 2024
dv4harr10
approved these changes
Dec 30, 2024
Co-authored-by: Dave Redmin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request modifies the code to use a DEB822 repo for all Debian platforms except for Debian Buster. This style of package repo is not supported by Debian Buster.
Note
This PR is based on #83 and should be merged after that one.
💭 Motivation and context
This simplifies the Ansible code and treats Buster as the special case, not Kali.
🧪 Testing
All automated tests pass.
✅ Pre-approval checklist