Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use old version on Ubuntu Noble #54

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jun 21, 2024

🗣 Description

This pull request modifies the role to install the 1.x version of aws/efs-utils on Ubuntu Noble.

💭 Motivation and context

Version 2.x pulls in a package that breaks the running ssh server. See #53 for more details.

🧪 Testing

All automated tests pass. I also built a Ubuntu Noble staging AMI with these changes as part of cisagov/ubuntu-server-packer#27 and verified that it functioned as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

See #53 for more details.
@jsf9k jsf9k added the bug This issue or pull request addresses broken functionality label Jun 21, 2024
@jsf9k jsf9k self-assigned this Jun 21, 2024
jsf9k added a commit to cisagov/ubuntu-server-packer that referenced this pull request Jun 21, 2024
…fs-utils

This is being done for testing purposes, and this change can be
reverted once cisagov/ansible-role-amazon-efs-utils#54 has been
approved and merged.
@jsf9k jsf9k marked this pull request as ready for review June 21, 2024 17:57
@jsf9k jsf9k enabled auto-merge June 21, 2024 17:57
@jsf9k jsf9k requested a review from a team June 21, 2024 17:57
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How unfortunate.

@jsf9k jsf9k merged commit 9614636 into develop Jun 24, 2024
53 checks passed
@jsf9k jsf9k deleted the bugfix/use-old-version-for-noble branch June 24, 2024 06:57
jsf9k added a commit to cisagov/ubuntu-server-packer that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants