Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Lint Issues Related to Whitespace/Prettier and Secrets #92

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Mar 18, 2024

🗣 Description

Exclude test snapshots from trailing-whitespace
Exclude dev.env.example from detect-private-key
Apply fixes from end-of-file-fixer, prettier, and trailing-whitespace

💭 Motivation and context

Closes issue #91

🧪 Testing

I recommend reviewing these changes in unified view (vs split view).

All tests pass.
Pre-commit checks pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

…-of-file-fixer, prettier, and trailing-whitespace.
@Matthew-Grayson Matthew-Grayson changed the title Resolve Lint Issues Related to Whitespace and Prettier. Resolve Lint Issues Related to Whitespace/Prettier and Secrets Mar 18, 2024
Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. prettier linter passing.

Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Prettier does pass now when pulling down and running locally.

@schmelz21 schmelz21 merged commit c3525eb into develop Mar 19, 2024
20 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve Lint Issues Flagged by end-of-file-fixer, prettier, and trailing-white-space.
3 participants