Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI Header Response to Browser and Crossfeed Logo Routing #78

Merged
merged 16 commits into from
Mar 27, 2024

Conversation

chrtorres
Copy link
Collaborator

@chrtorres chrtorres commented Mar 14, 2024

🗣 Description

  • Fixed an issue preventing responsiveness from the UI header.
  • Adjusted NavLink styling.
  • Corrected Crossfeed logo routing incorrectly.

💭 Motivation and context

Closes issues 16 & 17.

🧪 Testing

Sign in as different user types and see if the header is correctly displayed and responsive.

📷 Screenshots

Full screen design

image

image

Small screen design

image

image

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@chrtorres chrtorres changed the title Fixed header response to browser, NavLink underline styling, and Cros… Fixed UI Header Response to Browser and Crossfeed Logo Routing Mar 14, 2024
@chrtorres chrtorres changed the title Fixed UI Header Response to Browser and Crossfeed Logo Routing Fix UI Header Response to Browser and Crossfeed Logo Routing Mar 18, 2024
@chrtorres chrtorres marked this pull request as ready for review March 18, 2024 18:02
@Matthew-Grayson Matthew-Grayson marked this pull request as draft March 19, 2024 15:29
@Matthew-Grayson Matthew-Grayson self-requested a review March 19, 2024 15:46
@chrtorres chrtorres marked this pull request as ready for review March 19, 2024 15:47
@chrtorres chrtorres marked this pull request as draft March 19, 2024 15:51
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrtorres chrtorres force-pushed the ui-header-issue16 branch 3 times, most recently from a2f2ca2 to 3c6ddf1 Compare March 19, 2024 18:19
@chrtorres chrtorres marked this pull request as ready for review March 19, 2024 19:15
@chrtorres chrtorres marked this pull request as draft March 19, 2024 19:17
@ameliav ameliav self-assigned this Mar 22, 2024
@ameliav ameliav marked this pull request as ready for review March 27, 2024 15:36
Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickviola nickviola merged commit bdcd9b4 into develop Mar 27, 2024
11 of 14 checks passed
@nickviola
Copy link
Collaborator

Tested in both Safari and Chrome.

Chrome:
Screenshot 2024-03-27 at 1 38 27 PM

Safari:
Screenshot 2024-03-27 at 1 38 39 PM

All tested and works as expected.

@nickviola nickviola deleted the ui-header-issue16 branch March 27, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Set Crossfeed Logo Link to Home UI: Adjust Header to Response to Browser
5 participants