-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI Header Response to Browser and Crossfeed Logo Routing #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sfeed logo routing to dashboard
chrtorres
changed the title
Fixed header response to browser, NavLink underline styling, and Cros…
Fixed UI Header Response to Browser and Crossfeed Logo Routing
Mar 14, 2024
chrtorres
changed the title
Fixed UI Header Response to Browser and Crossfeed Logo Routing
Fix UI Header Response to Browser and Crossfeed Logo Routing
Mar 18, 2024
chrtorres
requested review from
aloftus23,
cduhn17,
Matthew-Grayson,
nickviola,
rapidray12 and
schmelz21
as code owners
March 18, 2024 18:02
This was
linked to
issues
Mar 19, 2024
chrtorres
force-pushed
the
ui-header-issue16
branch
from
March 19, 2024 15:34
34d60bb
to
3c6ddf1
Compare
cduhn17
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chrtorres
force-pushed
the
ui-header-issue16
branch
3 times, most recently
from
March 19, 2024 18:19
a2f2ca2
to
3c6ddf1
Compare
nickviola
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
💭 Motivation and context
Closes issues 16 & 17.
🧪 Testing
Sign in as different user types and see if the header is correctly displayed and responsive.
📷 Screenshots
Full screen design
Small screen design
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist