Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited Domain Details Severity Level Formatting (CRASM-1055) #749

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

hawkishpolicy
Copy link
Collaborator

@hawkishpolicy hawkishpolicy commented Dec 31, 2024

  • Brought the formatting of irregular severity levels displayed inside of Domain Details into line with the remainder of the app.

🗣 Description

  • Forced title case on all severity levels.
  • Null, N/A, undefined, and empty strings are now displayed as "N/A".
  • Low, Medium, High, and Critical severity levels remain the same.
  • All other values are now displayed as "Other".
  • Brought in the corresponding severity level color values as well.

💭 Motivation and context

  • Ensures the formatting of irregular severity levels remains constant across the app.
  • Closes CRASM-1055

🧪 Testing

  • tested locally.

📷 Screenshots (if appropriate)

Screenshot 2024-12-31 at 2 12 54 PM Screenshot 2024-12-31 at 2 13 07 PM

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

- Forced title case on all severity levels.
- Null, N/A, undefined, and empty strings are now displayed as "N/A".
- Low, Medium, High, and Critical severity levels remain the same.
- All other values are now displayed as "Other".
- Brought in the corresponding severity level color values as well.
@hawkishpolicy hawkishpolicy self-assigned this Dec 31, 2024
@hawkishpolicy hawkishpolicy changed the title Edited Domain Details Severity Level Formatting Edited Domain Details Severity Level Formatting (CRASM-1055) Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant