Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored FilterTags.tsx to maintain consistent display of the FilterTag components #738

Conversation

lwersiy
Copy link
Collaborator

@lwersiy lwersiy commented Dec 11, 2024

🗣 Description

This PR Resolves the inconsistent sorting of FilterTags of the FilterDrawer components.
It sets up a consistent display of of FilterTags regardless of filtering order.

💭 Motivation and context

Closes https://maestro.dhs.gov/jira/browse/CRASM-931

🧪 Testing

Tested Locally

📷 Screenshots (if appropriate)

Before implementation

Screenshot 2024-12-09 at 12 40 12 PM

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@lwersiy lwersiy self-assigned this Dec 12, 2024
@lwersiy lwersiy closed this Dec 12, 2024
@lwersiy lwersiy deleted the Refactor-FilterTags-to-be-in-a-consistent-order-as-FilterDrawer-Components branch December 12, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant