Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cache Control Headers (CRASM-667) #694

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

hawkishpolicy
Copy link
Collaborator

  • Added Cache-Control header with a timeout of 60 minutes in an effort to prevent Users from needing to 'hard reset' their browser after updates to Production.

🗣 Description

  • Amended app.ts, docs.js, and api.js with custom middleware.
  • Cache-Control headers are set to 'private, must-revalidate, max-age=3600

💭 Motivation and context

🧪 Testing

  • Tested locally.
  • Chrome appears to be calling for new resources once max-age is hit.
  • Will know if this fixes the hard reset problem once the it is merged and a new PR follows it.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

- 60 to 3600 seconds
@schmelz21 schmelz21 merged commit 0be576d into develop Oct 22, 2024
19 of 22 checks passed
@schmelz21 schmelz21 deleted the Page-Cache-Timeout-CRASM-667 branch October 22, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants