Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crasm 703/convert search endpoints #692

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

nickviola
Copy link
Collaborator

@nickviola nickviola commented Oct 17, 2024

🗣 Description

Closes CRASM-703. Adds python rewritten /search and /search/export endpoint logic. Will require further testing upon deployment, but base code and endpoints are there for ElasticSearch.

💭 Motivation and context

CRASM-703

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@nickviola nickviola changed the base branch from develop to AL-python-serverless October 17, 2024 14:58
@aloftus23 aloftus23 merged commit 5f19e15 into AL-python-serverless Oct 25, 2024
5 of 9 checks passed
@aloftus23 aloftus23 deleted the CRASM-703/convert-search-endpoints branch October 25, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants