-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up P&E's SQS process #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloftus23
requested review from
cduhn17,
Matthew-Grayson,
nickviola,
rapidray12 and
schmelz21
as code owners
March 14, 2024 19:53
rapidray12
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a fan of magic numbers (e.g. 604200). We need to clean those up. Also we need to come up with a new acronym. Maybe switch from PE to XFD
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Clean up the P&E SQS process. The old flow is described in this PR.
Instead of using ECS services to manage concurrent Fargate tasks, we can simply generate Fargate tasks through "ECS Run tasks". The issue with ECS services is that you can set a desired count of concurrent tasks (say 10), but if one finishes the script early, it will start a new one even though there's nothing left to run. We want tasks to complete and then shut down, which ECS run task ensures.
Also, this method removes the need of a "Control" SQS queue that parses messages into scan specific queues. Now we only need a scan specific queue.
💭 Motivation and context
Save costs and time running scans through SQS, lambda, and Fargate.
🧪 Testing
Tested locally and passes checks.
📷 Screenshots (if appropriate)
OLD:
NEW:
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist