Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions to EC2 to describe running Fargates #532

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Aug 13, 2024

🗣 Description

Add permissions to describe Fargate asks to the EC2 instance.

💭 Motivation and context

The EC2 is the control center that launches the SQS and Fargate scan process. With scans that require limited API access (limited number of running containers), we need to make sure there aren't any existing containers for each scan so we don't go past the limit of concurrent containers per scan.

With these permissions we can check before launching.

🧪 Testing

Passes terraform plan nad formatting.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit ac248bc into develop Aug 15, 2024
15 of 18 checks passed
@schmelz21 schmelz21 deleted the AL-add-EC2-permissions branch August 15, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants