Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS #5

Merged
merged 20 commits into from
Mar 6, 2024
Merged

Update CODEOWNERS #5

merged 20 commits into from
Mar 6, 2024

Conversation

cduhn17
Copy link
Collaborator

@cduhn17 cduhn17 commented Jan 3, 2024 •
edited by aloftus23
Loading

🗣 Description

Update default CODEOWNERS

💭 Motivation and context

We have more CODEOWNERS than what is listed inthe CODEOWNERS

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 5, 2024
View reviewed changes
backend/src/api/docker-events.ts Dismissed Show dismissed Hide dismissed
backend/src/tasks/lambda-client.ts Dismissed Show dismissed Hide dismissed
backend/src/tasks/dotgov.ts Fixed Show fixed Hide fixed
backend/src/api/app.ts Fixed Show resolved Hide resolved
backend/src/api/app.ts Fixed Show resolved Hide resolved
backend/src/api/app.ts Fixed Show resolved Hide resolved
backend/src/api/app.ts Fixed Show resolved Hide resolved
backend/src/tasks/checkUserExpiration.ts Fixed Show fixed Hide fixed
@cduhn17 cduhn17 added the upstream update This issue or pull request pulls in upstream updates label Mar 5, 2024
@cduhn17 cduhn17 requested review from nickviola and aloftus23 March 5, 2024 19:34
@Matthew-Grayson Matthew-Grayson requested a deployment to production March 6, 2024 16:57 — with GitHub Actions Abandoned
@cduhn17 cduhn17 marked this pull request as ready for review March 6, 2024 17:30
@cduhn17 cduhn17 requested review from schmelz21 and rapidray12 March 6, 2024 17:32
@cduhn17
Copy link
Collaborator Author

cduhn17 commented Mar 6, 2024

@dav3r , @jsf9k
Disregard request to review on this PR.

Matthew-Grayson
Matthew-Grayson approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! All CodeQL issues are resolved and the infrastructure pipeline looks good to go on the staging side.

rapidray12
rapidray12 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows us to turn the crank of the LZ Post Deployment team forking/pulling this repo

dav3r
dav3r requested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take care of one small, but important change before I approve.

.github/CODEOWNERS Outdated Show resolved Hide resolved
dav3r
dav3r approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved without full review or addressing all linter issues at the request of @cduhn17 so that downstream work can proceed.

Please address the remaining issues as soon as possible in subsequent PRs.

@cduhn17 cduhn17 merged commit d21acb8 into develop Mar 6, 2024
21 of 23 checks passed
@jsf9k jsf9k mentioned this pull request Mar 6, 2024
Closed
3 tasks
This was referenced Mar 7, 2024
Closed
Open
Closed
Merged
Closed
@cduhn17 cduhn17 deleted the CD-update-CODEOWNERS branch May 22, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rapidray12 rapidray12 rapidray12 approved these changes

@Matthew-Grayson Matthew-Grayson Matthew-Grayson approved these changes

@aloftus23 aloftus23 aloftus23 approved these changes

@dav3r dav3r dav3r approved these changes

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

@jsf9k jsf9k Awaiting requested review from jsf9k jsf9k is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

Assignees
No one assigned
Labels
upstream update This issue or pull request pulls in upstream updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cduhn17 @dav3r @aloftus23 @Matthew-Grayson @rapidray12