Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update elasticache terraform to modify VPC cidr notation #470

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

cduhn17
Copy link
Collaborator

@cduhn17 cduhn17 commented Jul 23, 2024

🗣 Description

AWS Elasticache modifyIAM CreatPolicy to terraform .tf file

💭 Motivation and context

Elasticache terraform needs an updated CIDR callout at the resource to deploy the Elasticache service in AWS

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more restrictive the CIDR blocks the better.

Copy link
Contributor

@aloftus23 aloftus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@cduhn17 cduhn17 merged commit 17e4e62 into develop Jul 23, 2024
15 of 18 checks passed
@cduhn17 cduhn17 deleted the cd_elasticache_add_create_policy branch July 23, 2024 13:01
@cduhn17 cduhn17 restored the cd_elasticache_add_create_policy branch July 23, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants