Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Organizations for RegionalAdmin User Type #47

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

nickviola
Copy link
Collaborator

@nickviola nickviola commented Mar 13, 2024

Filter Organizations for RegionalAdmin User Type

🗣 Description

Closes #23 Filter Organizations for RegionalAdmin User Type in UI to make sure that regionalAdmin user types don't see all organizations.

💭 Motivation and context

Leadership requests that regionalAdmin users shouldn't be able to see all organizations, but rather only organizations in their specific region.

🧪 Testing

Confirm that regionalAdmin user types don't see all organizations, but rather only orgs in their region?

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@nickviola nickviola self-assigned this Mar 13, 2024
@nickviola nickviola changed the title Issue 23/region admin filtered organizations Filter Organizations for RegionalAdmin User Type Mar 13, 2024
@nickviola nickviola requested review from ameliav and JCantu248 March 13, 2024 19:04
Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ameliav
Copy link
Contributor

ameliav commented Mar 13, 2024

There's a linter error on line 22 to change == to ===. Besides that, looks good!

Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@nickviola nickviola merged commit a74ab95 into develop Mar 15, 2024
9 of 14 checks passed
@nickviola nickviola deleted the issue-23/region-admin-filtered-organizations branch March 15, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Region Admin Only can See Region Organization
3 participants