Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update elasticache terraform to add CreatePolicy #459

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

cduhn17
Copy link
Collaborator

@cduhn17 cduhn17 commented Jul 19, 2024

πŸ—£ Description

AWS Elasticache add IAM CreatPolicy to terraform .tf file

πŸ’­ Motivation and context

Elasticache needs an IAM policy to create the Elasticache service in AWS

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

βœ… Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

βœ… Post-merge checklist

  • Create a release.

@cduhn17 cduhn17 marked this pull request as ready for review July 19, 2024 13:50
Copy link
Contributor

@aloftus23 aloftus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough

@rapidray12 rapidray12 merged commit 7da4afe into develop Jul 19, 2024
15 of 18 checks passed
@rapidray12 rapidray12 deleted the cd_elasticache_add_create_policy branch July 19, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants