Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions to all icons in the Admin Tools Notifications page #380

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

ameliav
Copy link
Contributor

@ameliav ameliav commented Jun 27, 2024

🗣 Description

Add descriptions to all icons in the Admin Tools Notifications page
JIRA CRASM-354 for 508 compliance

💭 Motivation and context

The Icons on the Admin Tools Notifications page are missing alternative text. Provide concise and meaningful text alternates for all non-text content. The description needs to provide enough information so that the purpose of non-text content can be understood even if it is removed.

🧪 Testing

In the console, all the icons have aria-labels that describe what the icon looks like and its purpose

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@ameliav ameliav self-assigned this Jun 27, 2024
@ameliav ameliav marked this pull request as ready for review June 27, 2024 18:09
Copy link
Contributor

@aloftus23 aloftus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built local and tested. Loots good!

Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit 856522c into develop Jun 27, 2024
11 of 14 checks passed
@schmelz21 schmelz21 deleted the 354-admin-tools-notification-icons-need-alt-text branch June 27, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants