343 UI Update Admin Tools Scan History table #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Code belongs on a separate branch.
- Added MUI Data Grid to ScanTasksView.
- Added MUI modal to ScanTasksView.
- Scan Task details are now displayed in the modal.
- Removed erroneous table from ScansView.
- Deleted the new table from ScansView.
- That table is on a separate branch
- Server-side pagination is implemented.
- Server-side filtering is not yet implemented.
- Changed page size to match other tables in app.
- Changed page size to 15. - Removed unused code for page size in .env. - Edited api call to accept page size variable. - Added page size to the query string in the frontend. - Built filter by name drop down component in DataGrid toolbar. - Built filter by status drop down component in DataGrid toolbar.
…n-tools-scan-history-table
- Refined Scan Name dropdown menu. - Refined Scan Status dropdown menu. - Added return to fetchScans function to prevent an empty table from rendering. - Formatted Created At and Updated At columns to display in a more readable format. - Added Logs and killScan to Details modal.
- Reverted killScan function. - Reenabled old table, expanded view, pagination, sorting, and filtering.
- added keys to list items in Scan Name dropdown. - added keys to list items in Scan Status dropdown. - added keys to children in Data Grid toolbar.
- Removed json parsing of output. Scan output does not require parsing. - Made modal large to showcase scan logs better. - Scan logs now display properly. - Added close button to modal. - Added aria-labels to buttons.
- New Data Grid allows for the passing in of Scan Task id versus row index. - Built modified killScan function to accept Scan Task id. - Both are enabled for testing.
- Removed old table, old pagination, and old expanded row. - Removed old imports. - Removed old helper functions.
hawkishpolicy
requested review from
aloftus23,
cduhn17,
Matthew-Grayson,
nickviola,
rapidray12 and
schmelz21
as code owners
aloftus23
requested changes
Jun 25, 2024
There was a problem hiding this comment.
- Filtering of Name and Status only works if the value exists. Say, dnstwist hasn't been run ever and you filter the Name by dnstwist; the table doesn't change at all. Instead should say No results or something
- The table needs to be sorted by the Created At column where the first entry is the most recent. I believe right now it is doing the opposite
Otherwise looks good!
…n-tools-scan-history-table
…//github.com/cisagov/XFD into 343-ui-update-admin-tools-scan-history-table
cduhn17
reviewed
Jun 26, 2024
| filters: tableFilters | ||
| } | ||
| } | ||
| ); | ||
| // if (result.length === 0) return; |
There was a problem hiding this comment.
Is this commented code needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
💭 Motivation and context
🧪 Testing
📷 Screenshots (if appropriate)
✅ Pre-approval checklist
in code comments.
✅ Pre-merge checklist
✅ Post-merge checklist