Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic accessibility features for describing pie chart image detai… #353

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

nickviola
Copy link
Collaborator

@nickviola nickviola commented Jun 18, 2024

closes issue 353 and 355. This PR slightly modifies the color scheme in order to reflect the patterns on the charts. This can be changed as needed, but this was what I used in testing that seems to look appropriate.

🗣 Description

This PR adds accessibility aria-labels to the pie charts on the landing page of the dashboard as well as adding patters to the coloring of these pie charts

💭 Motivation and context

To add accessibility features to meet 508 standards.

🧪 Testing

Check the Pie Chart's accessibility with Voiceover or ANDI tool. Also confirm variance in color and patterns.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@nickviola nickviola self-assigned this Jun 27, 2024
@ameliav ameliav self-requested a review June 27, 2024 19:50
@ameliav
Copy link
Contributor

ameliav commented Jun 27, 2024

Looks like both pie charts are now are text labeled completely and display different patterns along with their different colors.

image

I found the long description of the pie chart with all the descriptors for the chart here.

image

@nickviola is there a reason you changed the color scheme though?

@nickviola nickviola marked this pull request as ready for review June 27, 2024 21:59
Copy link
Collaborator

@hawkishpolicy hawkishpolicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit 049e516 into develop Jul 1, 2024
11 of 14 checks passed
@schmelz21 schmelz21 deleted the issue-353/pie-chart-accessibility-cleanup branch July 1, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants