Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xpanse to the SQS process #351

Merged
merged 7 commits into from
Jul 17, 2024
Merged

Add Xpanse to the SQS process #351

merged 7 commits into from
Jul 17, 2024

Conversation

aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Jun 18, 2024

fixes #323

πŸ—£ Description

Add xpanse scan to the SQS process.

πŸ’­ Motivation and context

Allows us to parallelize and schedule more efficiently.

πŸ§ͺ Testing

Passes pre-commit and pytests.

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

βœ… Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

βœ… Post-merge checklist

  • Create a release.

@aloftus23 aloftus23 self-assigned this Jun 18, 2024
Copy link
Contributor

@DJensen94 DJensen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in future iterations we should remove HIBP

@rapidray12
Copy link
Collaborator

Approved

@rapidray12 rapidray12 merged commit 581442c into develop Jul 17, 2024
21 of 25 checks passed
@rapidray12 rapidray12 deleted the AL-add-xpanse-SQS branch July 17, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Xpanse to SQS
3 participants