Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes for minio and redirect s3 client to minio for local dev #341

Merged

Conversation

nickviola
Copy link
Collaborator

@nickviola nickviola commented Jun 13, 2024

🗣 Description

Fixes Minio Docker deployment issues locally and redirects s3 Client requests to local minio replica s3 instance.

💭 Motivation and context

Allows for local testing with s3 and adds the ability to not have to hit the actual s3 buckets which require some permission changes for individual AWS IAM roles.

🧪 Testing

  • Make sure the local .env file has these parameters set exactly as shown (Replace if the values are already set):
    AWS_ACCESS_KEY_ID=aws_access_key
    AWS_SECRET_ACCESS_KEY=aws_secret_key
    EMAIL_BUCKET_NAME=crossfeed-local-exports
  • Rebuild the project or run ./rebuild.sh in the root of the project.
  • Make sure that minio docker container is running
  • Navigate to http://localhost:9000/minio/login
  • Login with values:
    AWS_ACCESS_KEY_ID=aws_access_key
    AWS_SECRET_ACCESS_KEY=aws_secret_key
  • Upload any documents needed to access in s3 (MAKE SURE FILENAMES MATCH WHAT WILL BE ADDED TO DMZ/PROD S3 VALUES)

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@nickviola nickviola added docker Pull requests that update Docker code backend labels Jun 13, 2024
@nickviola nickviola requested review from ameliav and JCantu248 June 13, 2024 17:19
@nickviola nickviola self-assigned this Jun 13, 2024
@schmelz21
Copy link
Collaborator

@nickviola - you have this in draft.. Should this be active?

Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickviola nickviola marked this pull request as ready for review June 27, 2024 19:56
@nickviola
Copy link
Collaborator Author

#355 adds checks for local static banner text. This should be merged first if we decide to go with this minio PR.

@aloftus23
Copy link
Contributor

aloftus23 commented Jun 27, 2024

#355 adds checks for local static banner text. This should be merged first if we decide to go with this minio PR.

reverted what I just did I didn't see that PR 🤦‍♂️

@schmelz21 schmelz21 merged commit 3a0961d into develop Jun 27, 2024
13 of 16 checks passed
@schmelz21 schmelz21 deleted the bugfix-fix-minio-deployment-and-redirect-to-local-s3 branch June 27, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants