Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update notification endpoint in helpers.ts #263

Merged
merged 1 commit into from
May 17, 2024
Merged

Update notification endpoint in helpers.ts #263

merged 1 commit into from
May 17, 2024

Conversation

ameliav
Copy link
Contributor

@ameliav ameliav commented May 17, 2024 •
edited
Loading

🗣 Description

Update notification endpoint in helpers.ts

💭 Motivation and context

This will fix the bug that logs standard and regional admin out

🧪 Testing

Logging in works.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@ameliav ameliav linked an issue May 17, 2024 that may be closed by this pull request
Fix backend notification maintenance logic #262
Closed
@ameliav ameliav marked this pull request as ready for review May 17, 2024 15:43
rapidray12
rapidray12 approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love one line changes

nickviola
nickviola approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ameliav ameliav self-assigned this May 17, 2024
@rapidray12 rapidray12 merged commit 0e0c403 into develop May 17, 2024
16 of 17 checks passed
@rapidray12 rapidray12 deleted the 262-fix-backend-notification-maintenance-logic branch May 17, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rapidray12 rapidray12 rapidray12 approved these changes

@nickviola nickviola nickviola approved these changes

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

@cduhn17 cduhn17 Awaiting requested review from cduhn17 cduhn17 is a code owner

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson Matthew-Grayson is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

Assignees

@ameliav ameliav

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix backend notification maintenance logic
3 participants
@ameliav @nickviola @rapidray12