Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstated printRef & printPDF #213

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Reinstated printRef & printPDF #213

merged 3 commits into from
Apr 30, 2024

Conversation

hawkishpolicy
Copy link
Collaborator

These changes were accidentally removed in a previous merge/commit.

🗣 Description

  • Reinstated the printRef reference and handlePDFDownload function to the Detail component.

💭 Motivation and context

They were mistakenly deleted in a previous merge/commit

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@hawkishpolicy
Reinstated printRef & printPDF functions in
6367b01 
RSCDetail.tsx

- These changes were accidentally removed in a previous commit
@hawkishpolicy hawkishpolicy linked an issue Apr 30, 2024 that may be closed by this pull request
Restore printRef and print pdf function #212
Closed
@hawkishpolicy hawkishpolicy marked this pull request as ready for review April 30, 2024 16:57
schmelz21
schmelz21 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - Merging as a secondary review.

@schmelz21 schmelz21 merged commit a409b0d into develop Apr 30, 2024
14 of 15 checks passed
@schmelz21 schmelz21 deleted the 212-restore-printref-and-print-pdf-function branch April 30, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmelz21 schmelz21 schmelz21 approved these changes

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

@cduhn17 cduhn17 Awaiting requested review from cduhn17 cduhn17 is a code owner

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson Matthew-Grayson is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore printRef and print pdf function
2 participants
@hawkishpolicy @schmelz21