Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up SQS code and fix visibility timeout #208

Merged
merged 7 commits into from
Apr 30, 2024
Merged

Clean-up SQS code and fix visibility timeout #208

merged 7 commits into from
Apr 30, 2024

Conversation

aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Apr 29, 2024

🗣 Description

This PR:

  • Cleans SQS code by removing unnecessary variables (i.e. Queue specific variables - can use generic instead)
  • Fixes containers picking up the same message: Increase visibility timeout to 5 hours (once a message is read, it won't be visible to be picked up again for 5 hours instead of 5 minutes)
  • Fixes Shodan to use different API keys for each container
  • Updates readme

💭 Motivation and context

Bug fixes and improve ease of adding new scans.

🧪 Testing

Tested locally and passes checks

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aloftus23 aloftus23 marked this pull request as ready for review April 29, 2024 20:46
Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit 555f630 into develop Apr 30, 2024
20 of 26 checks passed
@schmelz21 schmelz21 deleted the SQS-fixes branch April 30, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants