Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

197 UI admin can edit user information #201

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

ameliav
Copy link
Contributor

@ameliav ameliav commented Apr 25, 2024

🗣 Description

UI admin can edit user information

💭 Motivation and context

Allow an admin to be able to update a user's user type from Crossfeed's UI.

🧪 Testing

See if the edit user button is present in the table and that updating a user's user type gets updated in the front end and database.

📷 Screenshots

Selecting an edit button from one of the rows will bring you to a dialog pop up. As of now, all fields in the form will be disabled to edit except the user type.
updateUsersCrossfeed

Message if the update was successful.
image

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@ameliav ameliav linked an issue Apr 25, 2024 that may be closed by this pull request
@ameliav ameliav marked this pull request as ready for review April 26, 2024 14:31
Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work!

Copy link
Collaborator

@JCantu248 JCantu248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just pulled locally and it tested successfully.

@nickviola nickviola merged commit 08e5f4a into develop Apr 29, 2024
22 of 23 checks passed
@nickviola nickviola deleted the 197-ui-admin-can-edit-user-information branch April 29, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Admin Can Edit User Information
4 participants