Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#169 Generate PDF Button for RSC Dashboard #196

Merged
merged 9 commits into from
Apr 30, 2024
Merged

#169 Generate PDF Button for RSC Dashboard #196

merged 9 commits into from
Apr 30, 2024

Conversation

hawkishpolicy
Copy link
Collaborator

@hawkishpolicy hawkishpolicy commented Apr 24, 2024 •
edited
Loading

Added print/download pdf of user assessment functionality

🗣 Description

  • Installed react-to-print module
  • User can print/download just their assessment versus the entire page
  • Added date to download file name

💭 Motivation and context

Allow users to print/download individual assessments.

closes #169

🧪 Testing

📷 Screenshots (if appropriate)

Screenshot 2024-04-24 at 2 40 51 PM Screenshot 2024-04-24 at 2 40 34 PM Screenshot 2024-04-24 at 2 43 17 PM

Uncomment this section if a screenshot is needed.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@hawkishpolicy hawkishpolicy self-assigned this Apr 24, 2024
@hawkishpolicy hawkishpolicy linked an issue Apr 24, 2024 that may be closed by this pull request
Generate PDF Button for RSC Dashboard #169
Closed
2 tasks
@hawkishpolicy hawkishpolicy marked this pull request as ready for review April 24, 2024 20:37
@ameliav ameliav self-requested a review April 25, 2024 13:36
ameliav
ameliav approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nickviola
nickviola approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@nickviola nickviola left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM There are some conflicts that need resolving prior to merge though.

@schmelz21 schmelz21 merged commit 708a7ba into develop Apr 30, 2024
14 of 15 checks passed
@schmelz21 schmelz21 deleted the 169-generate-pdf-button-for-rsc-dashboard branch April 30, 2024 15:18
cisagovbot pushed a commit that referenced this pull request Nov 20, 2024
@jsf9k
Merge pull request #196 from cisagov/improvement/add-a-lower-bound-pi…
f7ccd9a 
…n-for-ansible-core

Bump up the lower bound on `ansible-core`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameliav ameliav ameliav approved these changes

@nickviola nickviola nickviola approved these changes

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

@cduhn17 cduhn17 Awaiting requested review from cduhn17 cduhn17 is a code owner

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson Matthew-Grayson is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

Assignees

@hawkishpolicy hawkishpolicy

Labels
frontend readysetcyber
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate PDF Button for RSC Dashboard
4 participants
@hawkishpolicy @nickviola @ameliav @schmelz21