Create rscSync to Pull Assessments from RSC Mission Instance #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change assessment.createdAt to @column() to store external createdAt date Add assessment.rscId field Change category.number and question.number fields to accept strings Add question.description field Remove resource.possibleResponses and make resource.url unique Rename response.text to response.selection
…to generate RSC questions.
…or axios url and variable names.
…ls-for-readysetcyber-data
…ler and fix questionDictionary.
…traint to unique for category.number.
Matthew-Grayson
changed the title
Matthew-Grayson
requested review from
aloftus23,
cduhn17,
nickviola,
rapidray12 and
schmelz21
as code owners
|
@Matthew-Grayson add labels to PR? |
3 tasks
…yml, and backend/src/tasks/ecs-client.yml.
…t logic save methods; remove console.logs.
cisagovbot
pushed a commit
that referenced
this pull request
Apr 30, 2024
…s/setup-python-5 Bump actions/setup-python from 4 to 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Create rscSync.ts to fetch assessments from RSC mission instance
Add rscSync to api/scans.ts and alphabetize ScanSchema/imports
Add rscSync to worker.ts and alphabetize imports/scanFn
Add call to fetchAssessmentsByUser to RSCRegister endpoint
Remove unused imports from api/users.ts
Add unique constraint to assessment.rscId and question.number
Add populateRscQuestions.sql to populate questions, resources, and categories
💭 Motivation and context
rscSync pulls recently completed/updated assessments from the ReadySetCyber mission instance and can be scheduled in Crossfeed's Admin Tools console.
It only saves assessments associated with users registered with Crossfeed.
Additionally, rscSync pulls all assessments for a user upon registration.
🧪 Testing
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist