Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and create admin-tools page and routing from scans #145

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

ameliav
Copy link
Contributor

@ameliav ameliav commented Apr 1, 2024

🗣 Description

Rename and create admin-tools page and routing from scans.

💭 Motivation and context

The current state of the project includes the “Web Page Scan” feature, which is considered out of scope for our project goals. Additionally, we need to ensure that all dependencies, especially related to routing, are properly addressed.

🧪 Testing

  • Change Scans page to Admin Tools (Only “Global Admin” Accessible)
  • Update header by moving link to right-left dropdown menu
  • No longer any routes directly to /scans
  • /scans -> /admin-tools

📷 Screenshots

Scans is now under "Admin Tools"
image

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@ameliav ameliav self-assigned this Apr 1, 2024
@ameliav ameliav linked an issue Apr 1, 2024 that may be closed by this pull request
3 tasks
@ameliav ameliav marked this pull request as ready for review April 2, 2024 13:39
Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. There are multiple locations where there is commented out code.

frontend/src/App.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now looks good.

@cduhn17 cduhn17 merged commit 4a4db8f into develop Apr 8, 2024
11 of 14 checks passed
@ameliav ameliav deleted the 133-update-scan-page-and-address-dependencies branch June 27, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Scan Page and Address Dependencies
4 participants