-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Playwright to XFD #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest removing some unnecessary quotes, but otherwise this looks fine to me. (With the caveat that I don't know the first thing about Playwright.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from the two minor things I noted.
It should also be noted that this PR has failing vulnerability checks that should be resolved. I don't know if those are the same as mentioned in #127, but regardless, it's always preferable to have all checks pass in a PR. Yes -These are being addressed currently in that ticket and have a high prioritization. This ticket is updated and would then force us to have clean checks each PR moving forward. |
Co-authored-by: Shane Frasier <[email protected]>
Co-authored-by: dav3r <[email protected]>
Co-authored-by: dav3r <[email protected]>
🗣 Description
Add Playwright tests to the Crossfeed repository.
💭 Motivation and context
Adds automated frontend UI tests to the project.
🧪 Testing
Test cases were created and tested against Crossfeed in its current state. All UI tests are passing and working in the intended manner.
run
cd frontend/xfd_playwright
then run
npx playwright install
finally run
npx playwright test
✅ Post-merge checklist