Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Playwright to XFD #126

Merged
merged 11 commits into from
Apr 9, 2024
Merged

Add Playwright to XFD #126

merged 11 commits into from
Apr 9, 2024

Conversation

JCantu248
Copy link
Collaborator

@JCantu248 JCantu248 commented Mar 25, 2024

🗣 Description

Add Playwright tests to the Crossfeed repository.

💭 Motivation and context

Adds automated frontend UI tests to the project.

🧪 Testing

Test cases were created and tested against Crossfeed in its current state. All UI tests are passing and working in the intended manner.

run cd frontend/xfd_playwright
then run npx playwright install
finally run npx playwright test

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@JCantu248 JCantu248 added test This issue or pull request adds or otherwise modifies test code frontend labels Mar 25, 2024
@JCantu248 JCantu248 self-assigned this Mar 25, 2024
@JCantu248 JCantu248 marked this pull request as ready for review March 26, 2024 19:18
Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21
Copy link
Collaborator

@jsf9k , @dav3r - Can your team take a look at this one. We are introducing Playwright into our tests. This initial commit is to establish the toolset and initial functionality. Follow-up PRs we will be issued to gain better coverage on UI tests.

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing some unnecessary quotes, but otherwise this looks fine to me. (With the caveat that I don't know the first thing about Playwright.)

.github/workflows/playwright.yml Outdated Show resolved Hide resolved
playwright/.gitignore Outdated Show resolved Hide resolved
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the two minor things I noted.

@dav3r
Copy link
Member

dav3r commented Apr 9, 2024

It should also be noted that this PR has failing vulnerability checks that should be resolved. I don't know if those are the same as mentioned in #127, but regardless, it's always preferable to have all checks pass in a PR.

Yes -These are being addressed currently in that ticket and have a high prioritization. This ticket is updated and would then force us to have clean checks each PR moving forward.

@JCantu248 JCantu248 merged commit e8ea2f1 into develop Apr 9, 2024
7 of 10 checks passed
@schmelz21 schmelz21 mentioned this pull request Apr 9, 2024
3 tasks
@JCantu248 JCantu248 deleted the add_playwright_ui_tests branch May 14, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend test This issue or pull request adds or otherwise modifies test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants