-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker-compose-check Hook #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm confused when you say:
First of all, #48 is an issue, not a PR. Did you mean PR #49, which resolved issue #48? Second, this PR still shows those two JSON-related pre-commit hooks failing. If those JSON hooks were passing thanks to the changes in #49, why are those changes not included in this PR? If they were, then the |
I've since merged develop into this branch and updated the PR language to reflect that all pre-commit hooks pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
🗣 Description
Add .env setup step to build.yml: addresses error by docker-compose-check hook.
💭 Motivation and context
The docker-compose-check hook relies on variables stored in a .env file. This file wasn't available in the GitHub Actions test environment, so I added a step to create it in the lint job.
Closes issue #108
🧪 Testing
All unit tests pass.
docker-compose-check hook passes.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist