Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OPA version from v0.70.0 to v1.0.0 #1485

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 23, 2024

🗣 Description

  • This pull request was created by a GitHub Action to bump ScubaGear's Open Policy Agent (OPA) executable version dependency.
  • Please fill out the rest of the template that the Action did not cover.

💭 Motivation and context

  • Bump to the latest OPA version v1.0.0

🧪 Testing

  • Currently a human should still check if bumping the OPA version affects ScubaGear.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

  • Demonstrate changes to the team for questions and comments.
    (Note: Only required for issues of size Medium or larger)

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@github-actions github-actions bot added the version bump This issue or pull request increments the version number label Dec 23, 2024
@schrolla schrolla added this to the Lionfish milestone Jan 6, 2025
@schrolla schrolla self-assigned this Jan 6, 2025
@buidav buidav self-requested a review January 13, 2025 18:15
Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloaded v1 OPA using Install-OPAforSCuBA.
Downloaded OPA

Ran the unit tests.
Rego

Compared results from a previous version of OPA v0.69.0
previousVersion

and version v1.0.0
v1

No issues found. Looks like epic #648 was successful in addressing our transition to OPA v1 :).

@schrolla
Copy link
Collaborator

@buidav Based on OPA 1.0.1 release of bugfixes, recommend closing this PR and reviewing 1.0.1 update so as not to merge support for bugged 1.0.0 version into supported versions.

@schrolla
Copy link
Collaborator

Closing in favor of PR #1526 which supersedes this one as a newer bugfix version of OPA came out and the v1.0.0 should not be included as an approved version as a result. Results from this PR can be used as a template for testing v1.0.1.

@schrolla schrolla closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version bump This issue or pull request increments the version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants