-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug where Pester fails to run but workflow pipeline itself doesn't fail #1470
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Small typo though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good functionally. Just one request to move the test file folder itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our test file process to date was usually to embed the files in a subdirectory under the place where the tests themselves were written. So would it make more sense to put the PesterTestFile directory under workflow?
🗣 Description
💭 Motivation and context
Created function to call Pester and check results to verify that it actually ran. Created Pester tests for the function and called the function in various places.
🧪 Testing
Closes: #1454
✅ Pre-approval checklist
I had to change some files related to PR 1450 b/c these changes were messing with that workflow. Rebase and merge will harmonize everything.
✅ Pre-merge checklist
✅ Post-merge checklist