Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up GitHub secrets #1504

Open
2 tasks
Tracked by #1512
james-garriss opened this issue Jan 9, 2025 · 0 comments
Open
2 tasks
Tracked by #1512

Clean up GitHub secrets #1504

james-garriss opened this issue Jan 9, 2025 · 0 comments
Labels
enhancement This issue or pull request will add new or improve existing functionality infrastructure Related to configuring infrastructure necessary for the project
Milestone

Comments

@james-garriss
Copy link
Collaborator

james-garriss commented Jan 9, 2025

💡 Summary

In general, there are two related concerns:

  • There are potentially some secrets that should be moved from GitHub secrets to Azure Key Vault (AKV).
  • There are potentially some secrets in GitHub secrets that should be "backed up" to AKV, as AKV allows us to view the secret.

This is related to the issue that will implement these changes in code: #1505

Motivation and context

We want to use the right tool for the job, taking advatange of the pros of each service.

Implementation notes

  • Determine if there are any GitHub secrets that should copied into AKV, not for automation to use but only for backup.
  • Move them.
  • Look through all GitHub secrets and determine which ones should be put into AKV instead, then move the secrets.
  • Move them.

Acceptance criteria

How do we know when this work is done?

  • All the secrets are where they are supposed to be.
  • All the backup of secrets are where they are supposed to be.
@james-garriss james-garriss added enhancement This issue or pull request will add new or improve existing functionality infrastructure Related to configuring infrastructure necessary for the project labels Jan 9, 2025
@schrolla schrolla added this to the Marlin milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality infrastructure Related to configuring infrastructure necessary for the project
Projects
None yet
Development

No branches or pull requests

2 participants