Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that secrets pulled from AKV are not sent to GitHub logs #1507

Open
1 task
Tracked by #1512
james-garriss opened this issue Jan 9, 2025 · 1 comment
Open
1 task
Tracked by #1512
Labels
enhancement This issue or pull request will add new or improve existing functionality infrastructure Related to configuring infrastructure necessary for the project
Milestone

Comments

@james-garriss
Copy link
Collaborator

james-garriss commented Jan 9, 2025

💡 Summary

This is related to: #1504 and #1505

Once we move all the required secrets to Azure Key Vault, we need to make sure that the secrets pulled from AKV are NOT accidentally displayed in GitHub logs when the workflows run.

Motivation and context

Revealing secrets is bad.

Implementation notes

There are potentially some technical solutions for avoiding the problem such as ::add-mask:: or setSecret().

See documentation here:

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#using-workflow-commands-to-access-toolkit-functions

Acceptance criteria

How do we know when this work is done?

  • No secrets are revealed in the GitHub logs.
@james-garriss james-garriss added enhancement This issue or pull request will add new or improve existing functionality infrastructure Related to configuring infrastructure necessary for the project labels Jan 9, 2025
@schrolla
Copy link
Collaborator

Integrate into code security epic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality infrastructure Related to configuring infrastructure necessary for the project
Projects
None yet
Development

No branches or pull requests

2 participants