Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the build release workflow #539

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

mitchelbaker-cisa
Copy link
Collaborator

@mitchelbaker-cisa mitchelbaker-cisa commented Dec 17, 2024

🗣 Description

The build_release workflow was written to target branch names with the format release-<version number>. Since we don't use release branches the workflow was failing. This PR addresses this problem by removing one of the GitHub Actions to generate release notes, and instead uses the gh-action-release action to generate release notes.

🧪 Testing

Generated a draft release with the new updates:

image

✅ Pre-approval checklist

  • Changes are limited to a single goal AND
    the title reflects this in a clear human readable format
  • Issue that this PR solves has been selected in the Development section
  • I have read and agree to LME's CONTRIBUTING.md document.
  • The PR adheres to LME's requirements in RELEASES.md
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.

✅ Pre-merge Checklist

  • All tests pass
  • PR has been tested and the documentation for testing is above
  • Squash and merge all commits into one PR level commit

✅ Post-merge Checklist

  • Delete the branch to keep down number of branches

@mitchelbaker-cisa mitchelbaker-cisa self-assigned this Dec 17, 2024
@mitchelbaker-cisa mitchelbaker-cisa linked an issue Dec 17, 2024 that may be closed by this pull request
@mitchelbaker-cisa mitchelbaker-cisa added the bug This issue or pull request addresses broken functionality label Dec 17, 2024
Mastermjr
Mastermjr approved these changes Dec 17, 2024
Copy link
Collaborator

@mreeve-snl mreeve-snl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@mitchelbaker-cisa mitchelbaker-cisa removed the request for review from cbaxley December 17, 2024 22:03
@mitchelbaker-cisa mitchelbaker-cisa merged commit 0d19788 into main Dec 17, 2024
5 checks passed
@mitchelbaker-cisa mitchelbaker-cisa deleted the mbaker-538-update-build-release-workflow branch December 17, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Update build_release.yml workflow
3 participants