Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Make POST/PUT payload visible in requests.json #823

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

vasuraman11
Copy link
Contributor

@vasuraman11 vasuraman11 commented Jun 1, 2022

The libmtev HTTP observer module and libmtev have been changed to expose the incoming HTTP payload if it is text, so that we can see the incoming payload using requests.json.

@vasuraman11 vasuraman11 requested a review from postwait June 1, 2022 05:11
@vasuraman11 vasuraman11 changed the title Make POST/PUT payload visible in backtrace and requests.json DRAFT: Make POST/PUT payload visible in backtrace and requests.json Jun 1, 2022
@postwait
Copy link
Member

postwait commented Jun 1, 2022

Am I reading this right that we're going to pay a large allocation and memcpy on every request now? This seems like a bad default performance sacrifice.

Perhaps http end points should opt into this.

@vasuraman11 vasuraman11 changed the title DRAFT: Make POST/PUT payload visible in backtrace and requests.json DRAFT: Make POST/PUT payload visible in requests.json Jun 2, 2022
@vasuraman11 vasuraman11 changed the title DRAFT: Make POST/PUT payload visible in requests.json DRAFT: Make POST/PUT payload visible in backtrace Jun 2, 2022
@vasuraman11 vasuraman11 changed the title DRAFT: Make POST/PUT payload visible in backtrace DRAFT: Make POST/PUT payload visible in requests.json Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants